Return-Path: marc@vangogh.CS.Berkeley.EDU 
Delivery-Date: Fri, 25 Mar 94 12:54:55 -0800
Return-Path: marc@vangogh.CS.Berkeley.EDU
Received: from toe.CS.Berkeley.EDU (toe.CS.Berkeley.EDU [128.32.149.117]) by nobozo.CS.Berkeley.EDU (8.6.4/8.6.3) with ESMTP id MAA06491 for <aoki>; Fri, 25 Mar 1994 12:54:55 -0800
Received: from vangogh.CS.Berkeley.EDU (vangogh.CS.Berkeley.EDU [128.32.130.2]) by toe.CS.Berkeley.EDU (8.6.4/8.1B) with ESMTP id MAA19103; Fri, 25 Mar 1994 12:56:20 -0800
Received: from localhost.Berkeley.EDU (localhost.Berkeley.EDU [127.0.0.1]) by vangogh.CS.Berkeley.EDU (8.6.7/8.6.6) with SMTP id MAA12418 for <aoki@toe.CS.Berkeley.EDU>; Fri, 25 Mar 1994 12:54:12 -0800
Message-Id: <199403252054.MAA12418@vangogh.CS.Berkeley.EDU>
X-Authentication-Warning: vangogh.CS.Berkeley.EDU: Host localhost.Berkeley.EDU didn't use HELO protocol
To: aoki@postgres.Berkeley.EDU
Date: Fri, 25 Mar 1994 12:54:11 -0800
From: Marc Teitelbaum <marc@vangogh.CS.Berkeley.EDU>


------- Forwarded Message

Received: from tmcs.tm.tno.nl ([192.43.212.100]) by vangogh.CS.Berkeley.EDU (8.6.7/8.6.6) with SMTP id IAA07269 for <marc@vangogh.cs.berkeley.edu>; Wed, 23 Mar 1994 08:14:59 -0800
Received: from ivcs.izf.tno.nl (ivcs.tm.tno.nl) by tmcs.tm.tno.nl (4.1/SMI-4.1)
	id AA02294; Wed, 23 Mar 94 17:14:57 +0100
Received: from rainbow.izf.tno.nl by ivcs.izf.tno.nl (5.0/SMI-SVR4)
	id AA04787; Wed, 23 Mar 1994 17:14:53 --100
Received: by rainbow.izf.tno.nl (5.0/SMI-SVR4)
	id AA00915; Wed, 23 Mar 1994 17:14:51 --100
Date: Wed, 23 Mar 1994 17:14:51 --100
From: tom@tm.tno.nl (Tom Vijlbrief)
Message-Id: <9403231614.AA00915@rainbow.izf.tno.nl>
To: marc@vangogh.CS.Berkeley.EDU
Subject: postgres fixes
Cc: Peter.van.Oosterom@fel.tno.nl
X-Sun-Charset: US-ASCII
Content-Length: 2250

Hi Marc,

I found a number of problems in your beta release.

Copy from stdin does not work correctly when reading from a file.

This is the fix (add 6 lines to monitor.c):

        while (!linedone) {             /* for each buffer ... */
            s = copybuf;
            buflen = COPYBUFSIZ;
            for (; buflen > 1 &&
                 !(linedone = ((c = getc(stdin)) == '\n' || c == EOF));
                 --buflen) {
                *s++ = c;
            }
 
            /* Bug fix for reading from stdin, tom@tm.tno.nl */
            if (c == EOF) {
              PQputline(".");
              copydone = true;
              break;
            }
 
            *s = '\0';
            PQputline(copybuf);
            if (firstload) {


Also ipcclean.sh could not be found when installing.

I also suggest setting umask to 022 in backend/commands/copy.c:

    else
    {
#if 1
        mode_t oldum= umask(022);
#endif
        if (pipe && IsUnderPostmaster) SendCopyBegin();
        if (IsUnderPostmaster)
        {
            fp = pipe ? Pfout : fopen(filename, "w");
        }
        else
        {
            fp = pipe ? stdout : fopen(filename, "w");
        }
#if 1
        umask(oldum);
#endif
        if (fp == NULL)
        {


Also the test in createuser could be:

if [ $ADDUSER"" != "t" ]

so that the script does not fail when the user is not yet in the
pg_user table (I noticed this when su-ed as postgres I tried
to add myself but the USER env variable was not set at postgres)

As a last point, I get these messages:

NOTICE:Mar 23 16:31:57:[54] (freeNext=34, freePrev=63, relname=pg_classnameind, blockNum=1, flags=0x14, refcount=0 0)
NOTICE:Mar 23 16:31:57:[55] (freeNext=52, freePrev=35, relname=pg_procidind, blockNum=2, flags=0x14, refcount=0 0)
NOTICE:Mar 23 16:31:57:[56] (freeNext=15, freePrev=37, relname=pg_procidind, blockNum=3, flags=0x14, refcount=0 0)

These are generated when adding operators

define operator <<  (arg1 = BOX2, arg2 = BOX2, procedure = Overleft2BoxBox,
   negator = !<<, restrict = intltsel, join = intltjoinsel)
\g


Could you please notify me of any additional changes you make
because I made a solaris port....


Thanks for the final postgres release, it works quite well....


Tom



------- End of Forwarded Message